Skip to content

Fix for ganalytics json builder#839

Merged
thinkingserious merged 1 commit intomasterfrom
ganalytics-fix
Sep 12, 2019
Merged

Fix for ganalytics json builder#839
thinkingserious merged 1 commit intomasterfrom
ganalytics-fix

Conversation

@thinkingserious
Copy link
Copy Markdown
Contributor

@thinkingserious thinkingserious commented Sep 12, 2019

Fixes #836

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

Checklist

  • [x ] I acknowledge that all my contributions will be made under the project's license

@thinkingserious thinkingserious added type: bug bug in the library status: code review request requesting a community code review or review from Twilio difficulty: easy fix is easy in difficulty labels Sep 12, 2019
Copy link
Copy Markdown
Contributor

@eshanholtz eshanholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thinkingserious thinkingserious merged commit f53941f into master Sep 12, 2019
@thinkingserious
Copy link
Copy Markdown
Contributor Author

Hello @thinkingserious,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@childish-sambino childish-sambino deleted the ganalytics-fix branch January 15, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: bug bug in the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'str' object has no attribute 'get()'

2 participants